Chapter 04 를 공부하고 테스트 코드를 추가하라 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
johngrib
commented
Mar 12, 2020
•
johngrib
commented
* 할인 조건은 할인 조건의 타입을 갖는다.
* 기존의 설계와 동일한 부분은 세 가지 뿐이다.
* title 을 인스턴스 변수로 포함한다.
* runningTime 을 인스턴스 변수로 포함한다.
* fee 를 인스턴스 변수로 포함한다.
* 가장 큰 차이점은 할인 조건 목록(discountConditions)이 포함되어 있다는 것.
* DiscountCondition 생성자를 추가했습니다. * DiscountConditionType.PERIOD 일 경우의 isDiscountable 테스트 코드를 작성했습니다.
테스트를 위해 Getter를 추가했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.