Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for https protocoll #9

Closed
felixmw opened this issue Aug 7, 2022 · 3 comments
Closed

Allow for https protocoll #9

felixmw opened this issue Aug 7, 2022 · 3 comments

Comments

@felixmw
Copy link

felixmw commented Aug 7, 2022

My pihole is running behind a reverse proxy and ssl encryption is applied. Since the 'http' protocol ist hard coded in your scripts I am not able to use your stream deck plugin. It would be great if one could define the protocol either as part of the address or as a separate variable.

Thanks a lot,
best,
Felix

@AquaRelliux
Copy link

Your steamdeck is on the same network as your pihole? You should use split-dns to avoid NAT problems also you should go directly to your pihole via http on your internal network. This will be better security wise and performance wise

@digas
Copy link

digas commented Jun 16, 2023

What do you have to do with and how our network is configured ? This is not the question or the request of the issue .
The question / request of the issue is can you change it to be able to use https request or not ? simple .
Imagine i have different networks all in the my same network , imagine i'm using pihole on a docker and i actually use VM's this is not the point and i believe it's no own will come here to put question about a pihole not working ..
The question is can you change from hardcoding allow the client to choose which protocol he wants to make the request over http or https ? thank you

johnholbrook added a commit that referenced this issue Jul 22, 2023
@johnholbrook
Copy link
Owner

This feature was added in version 1.2.0, which is now available from the releases page or from the stream deck store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants