Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alternate names, method description #161

Merged
merged 18 commits into from Mar 22, 2021
Merged

Add alternate names, method description #161

merged 18 commits into from Mar 22, 2021

Conversation

johnlees
Copy link
Member

@johnlees johnlees commented Mar 15, 2021 •
edited

  • Add unwords
  • Add methods
  • Add citation
  • Update docs with all of the above

Closes #153

@johnlees johnlees marked this pull request as ready for review March 17, 2021 13:11
@johnlees johnlees linked an issue Mar 17, 2021 that may be closed by this pull request
genome name changed in output NJ_tree #159
Closed
nickjcroucher
nickjcroucher approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@nickjcroucher nickjcroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, nothing major, can try to test the unwords output asap.

PopPUNK/citation.py Outdated Show resolved Hide resolved
PopPUNK/citation.py Show resolved Hide resolved
PopPUNK/network.py Outdated Show resolved Hide resolved
PopPUNK/network.py Outdated Show resolved Hide resolved
PopPUNK/unwords.py Show resolved Hide resolved
PopPUNK/network.py Show resolved Hide resolved
johnlees and others added 3 commits March 22, 2021 17:33
@johnlees johnlees merged commit e361eec into master Mar 22, 2021
@johnlees johnlees deleted the VLKC branch March 22, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickjcroucher nickjcroucher nickjcroucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

genome name changed in output NJ_tree Add alternative strain names
2 participants
@johnlees @nickjcroucher