Skip to content

Commit

Permalink
updates contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
housseindjirdeh committed Oct 24, 2019
1 parent 5d16ec1 commit 6d4ce77
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Contributing

* In order to have a library added to the extension, please ensure that the `test` portion of the block of code for the library includes more than just `window.LIBRARY_HERE` as part of the `if` statement for the existence of a library. In the example below, note that in addition to `win.d3`, `win.d3.select` (one of the API methods) is also being tested for:
* In order to have a library added to the extension, please ensure that:

- A unique `id` is assigned.
- The `test` portion of the block of code for the library includes more than just `window.LIBRARY_HERE` as part of the `if` statement for the existence of a library. In the example below, note that in addition to `win.d3`, `win.d3.select` (one of the API methods) is also being tested for.

```JavaScript
'D3': {
id: 'd3',
icon: 'd3',
url: 'http://d3js.org',
test: function(win) {
Expand Down

0 comments on commit 6d4ce77

Please sign in to comment.