Select columns from dataframe using a list (alteryx#615)

* Select columns from dataframe using a list Previously the columns were in a set, but this doesn not work on pandas 0.23. * Update changelog * Update changelog
johnnyheineken · Jul 7, 2019 · d2d2274 · d2d2274
1 parent 57d7cf7
commit d2d2274
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
@@ -5,12 +5,14 @@ Changelog
 **Future Release**
     * Enhancements
     * Fixes
-      * Change type of features calculated on Index features to Categorical (:pr:`602`)
+        * Select columns of dataframe using a list (:pr:`615`)
+        * Change type of features calculated on Index features to Categorical (:pr:`602`)
     * Changes
     * Documentation Changes
     * Testing Changes
 
     Thanks to the following people for contributing to this release:
+    :user:`CJStadler`
 
 **v0.9.0** June 19, 2019
     * Enhancements

diff --git a/featuretools/computational_backends/feature_set_calculator.py b/featuretools/computational_backends/feature_set_calculator.py
@@ -617,11 +617,11 @@ def _necessary_columns(self, entity, feature_names):
                          if isinstance(v, (variable_types.Index,
                                            variable_types.Id,
                                            variable_types.TimeIndex))}
-        features = [self.feature_set.features_by_name[name]
-                    for name in feature_names]
+        features = (self.feature_set.features_by_name[name]
+                    for name in feature_names)
         feature_columns = {f.variable.id for f in features
                            if isinstance(f, IdentityFeature)}
-        return index_columns | feature_columns
+        return list(index_columns | feature_columns)
 
 
 def _can_agg(feature):