SOS-1282 #214
Closed
SOS-1282 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ploy_listener/so-portlet.
…the the "import.shared" in build.xml got moved from one plugin to the other
…ill be printing out the messages. The way logging levels work. See logging hierarchy in http://logging.apache.org/log4j/1.2/manual.html. When you say that in the properties that you want to print DEBUG, then it will print DEBUG and everything lower than it. And INFO is lower than DEBUG, so it'll still print the messages. By switching the property to INFO, we will only print stuff lower than it, and DEBUG is higher than INFO, so no messages will get printed. The order is TRACE, DEBUG, INFO, WARN, ERROR, FATAL.
… what you wanted, can you double check the comment? Is that a true statement?
…d practice. In this case, if we import so.util.RoleConstants and not the portal one, we can use the RoleConstants.SOCIAL_OFFICE_USER
…SocialOffice" vs "socialOfficeCleanup". Methods take an action and do something. 2.) See updateGroups, I used the pattern of "for (int i = 0; i <= pages; i++) {", just search for Indexer.DEFAULT_INTERVAL in portal master. It prevents us loading EVERY community into memory. Imagine if there are 1 million. This allows us to paginate. 3.) I don't see the point of "updateUsers". When you delete the Social Office User role, the logic to trigger the RoleListener should already happen in "deleteSocialOfficeUserRole". But if you did need that logic, also use the pattern of "for (int i = 0; i <= pages; i++) {" or you will get slammed loading 1 million users from the db.
…ifications portlet
…operties for variable replacement 2.) only set the payload if there is a response
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jonathan,
this fixed the ie7 issue for me in EE of SO 2.0:
.ie7 #so-sidebar .so-portlet-sites ul.site-list li .name {
max-width: 115px;
}
I tried to put this fix to core CE, hope I found correct place in the css file.