Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS-1282 #214

Closed
wants to merge 96 commits into from
Closed

SOS-1282 #214

wants to merge 96 commits into from

Commits on Oct 17, 2012

  1. Copy the full SHA
    3b0c480 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2012

  1. LPS-30554 fix messaging-spring. Need to define destination liferay/de…

    …ploy_listener/so-portlet.
    johnnyhowey authored and brianchandotcom committed Oct 18, 2012
    Copy the full SHA
    7aecb7c View commit details
    Browse the repository at this point in the history
  2. SOS-1252

    johnnyhowey authored and brianchandotcom committed Oct 18, 2012
    Copy the full SHA
    73ed0ca View commit details
    Browse the repository at this point in the history
  3. LPS-30470 Make consistent

    shinnlok authored and brianchandotcom committed Oct 18, 2012
    Copy the full SHA
    3715ea1 View commit details
    Browse the repository at this point in the history
  4. LPS-30470 Fix null pointer

    shinnlok authored and brianchandotcom committed Oct 18, 2012
    Copy the full SHA
    6cc02c3 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    68967c4 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    51cc9b8 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    a1c01e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2012

  1. Source formatting

    brianchandotcom committed Oct 19, 2012
    Copy the full SHA
    57f7dea View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    91bcede View commit details
    Browse the repository at this point in the history
  3. SOS-1221 Format-source

    johnnyhowey committed Oct 19, 2012
    Copy the full SHA
    2af26f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2012

  1. SOS-1221 Reran ant "setup-eclipse" in so-hook and so-portlet because …

    …the the "import.shared" in build.xml got moved from one plugin to the other
    brianchandotcom committed Oct 20, 2012
    Copy the full SHA
    40a3ef8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    02cc3e0 View commit details
    Browse the repository at this point in the history
  3. SOS-1221 Proper fix for changing logging level, otherwise, we will st…

    …ill be printing out the messages. The way logging levels work. See logging hierarchy in http://logging.apache.org/log4j/1.2/manual.html. When you say that in the properties that you want to print DEBUG, then it will print DEBUG and everything lower than it. And INFO is lower than DEBUG, so it'll still print the messages. By switching the property to INFO, we will only print stuff lower than it, and DEBUG is higher than INFO, so no messages will get printed. The order is TRACE, DEBUG, INFO, WARN, ERROR, FATAL.
    brianchandotcom committed Oct 20, 2012
    Copy the full SHA
    008cf6e View commit details
    Browse the repository at this point in the history
  4. SOS-1221 Catch only the exception, and add a message. I think this is…

    … what you wanted, can you double check the comment? Is that a true statement?
    brianchandotcom committed Oct 20, 2012
    Copy the full SHA
    5aa03a3 View commit details
    Browse the repository at this point in the history
  5. SOS-1221 I never (or rarely) use import .* in Java. I think it's a ba…

    …d practice. In this case, if we import so.util.RoleConstants and not the portal one, we can use the RoleConstants.SOCIAL_OFFICE_USER
    brianchandotcom committed Oct 20, 2012
    Copy the full SHA
    8858f83 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    a461708 View commit details
    Browse the repository at this point in the history
  7. SOS-1221 1.) method names should start with a verb, so it is "cleanUp…

    …SocialOffice" vs "socialOfficeCleanup". Methods take an action and do something. 2.) See updateGroups, I used the pattern of "for (int i = 0; i <= pages; i++) {", just search for Indexer.DEFAULT_INTERVAL in portal master. It prevents us loading EVERY community into memory. Imagine if there are 1 million. This allows us to paginate. 3.) I don't see the point of "updateUsers". When you delete the Social Office User role, the logic to trigger the RoleListener should already happen in "deleteSocialOfficeUserRole". But if you did need that logic, also use the pattern of "for (int i = 0; i <= pages; i++) {" or you will get slammed loading 1 million users from the db.
    brianchandotcom committed Oct 20, 2012
    Copy the full SHA
    5b3d7de View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    5037816 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    927943a View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    4b084f2 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    6fb7bf4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2012

  1. LPS-30598 Manual changes

    shuyangzhou authored and brianchandotcom committed Oct 22, 2012
    Copy the full SHA
    c4340b8 View commit details
    Browse the repository at this point in the history
  2. LPS-30598 Regenerate

    brianchandotcom committed Oct 22, 2012
    Copy the full SHA
    4fee2c5 View commit details
    Browse the repository at this point in the history
  3. Source formatting

    brianchandotcom committed Oct 22, 2012
    Copy the full SHA
    e03442b View commit details
    Browse the repository at this point in the history
  4. LPS-30170 Regenerate

    brianchandotcom committed Oct 22, 2012
    Copy the full SHA
    a27a185 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    05787b5 View commit details
    Browse the repository at this point in the history
  6. LPS-30559 1.) Follow pattern in test-pacl/*/liferay-plugin-package.pr…

    …operties for variable replacement 2.) only set the payload if there is a response
    brianchandotcom committed Oct 22, 2012
    Copy the full SHA
    6ecc5ab View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    03a3fee View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    57085b9 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    040079a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2012

  1. Copy the full SHA
    61604be View commit details
    Browse the repository at this point in the history
  2. Source formatting

    hhuijser committed Oct 23, 2012
    Copy the full SHA
    8ec0733 View commit details
    Browse the repository at this point in the history
  3. LPS-30363

    brianchandotcom committed Oct 23, 2012
    Copy the full SHA
    481fbb7 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    f3551ad View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    849562b View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    670e0e6 View commit details
    Browse the repository at this point in the history
  7. SOS-1257 Sort

    brianchandotcom committed Oct 23, 2012
    Copy the full SHA
    974934f View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    85287e3 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    b8b078c View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    b8a7c2a View commit details
    Browse the repository at this point in the history
  11. SOS-1254 Sort

    brianchandotcom committed Oct 23, 2012
    Copy the full SHA
    9f47ad7 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    c8aea69 View commit details
    Browse the repository at this point in the history
  13. SOS-1232 Source Formatting

    aarondelani authored and brianchandotcom committed Oct 23, 2012
    Copy the full SHA
    08bc7cd View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    4880a39 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2012

  1. Copy the full SHA
    09ce8fa View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f3f4d88 View commit details
    Browse the repository at this point in the history
  3. Source formatting

    brianchandotcom committed Oct 24, 2012
    Copy the full SHA
    d6552a1 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    04d21c2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    cee8a58 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    b1a0901 View commit details
    Browse the repository at this point in the history
  7. LPS-30635 Minor fixes

    eduardolundgren committed Oct 24, 2012
    Copy the full SHA
    e665a9f View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    5316d73 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    a1b391b View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    43e6caa View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    9ac65de View commit details
    Browse the repository at this point in the history
  12. LPS-30641

    brianchandotcom committed Oct 24, 2012
    Copy the full SHA
    36cdeb4 View commit details
    Browse the repository at this point in the history
  13. LRDCOM-2954CE

    kevincho authored and brianchandotcom committed Oct 24, 2012
    Copy the full SHA
    44e00d0 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    1bc1f0c View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    7e165f5 View commit details
    Browse the repository at this point in the history
  16. LRDCOM-2716

    christine-huang authored and brianchandotcom committed Oct 24, 2012
    Copy the full SHA
    d20d4fc View commit details
    Browse the repository at this point in the history
  17. Copy the full SHA
    455dee6 View commit details
    Browse the repository at this point in the history
  18. SOS-1260

    johnnyhowey committed Oct 24, 2012
    Copy the full SHA
    2e58551 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2012

  1. LPS-27965 Set user's language and country to OpenSocial gadgets by lo…

    …cale
    Dennis Ju authored and brianchandotcom committed Oct 25, 2012
    Copy the full SHA
    b1d7a38 View commit details
    Browse the repository at this point in the history
  2. LPS-27965 Set user's language and country to OpenSocial gadgets by lo…

    …cale
    Michael Young authored and brianchandotcom committed Oct 25, 2012
    Copy the full SHA
    cd0b287 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4c4012e View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2012

  1. Copy the full SHA
    be4eed7 View commit details
    Browse the repository at this point in the history
  2. LPS-30688 Sort

    hhuijser committed Oct 26, 2012
    Copy the full SHA
    8878725 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2012

  1. LPS-27019

    Michael Young authored and brianchandotcom committed Oct 27, 2012
    Copy the full SHA
    adcacc3 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    201888e View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    08fe4cf View commit details
    Browse the repository at this point in the history
  4. Source formatting

    brianchandotcom committed Oct 27, 2012
    Copy the full SHA
    9ac36c2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    35610b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2012

  1. Remove unused icon

    brianchandotcom committed Oct 29, 2012
    Copy the full SHA
    0968519 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2012

  1. Copy the full SHA
    e0d43ef View commit details
    Browse the repository at this point in the history
  2. SOS-1264 IE7 borders missing or misaligned in contacts center, member…

    …s, and messages pages
    ethib137 authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    460bc0c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    03bc374 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    508dd5f View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    85e00f6 View commit details
    Browse the repository at this point in the history
  6. SOS-1268 IE7 bugs on SO Sidebar

    ethib137 authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    047a532 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    3d590fa View commit details
    Browse the repository at this point in the history
  8. SOS-1270 IE7 bug on Home page

    ethib137 authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    8045611 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    ebcad17 View commit details
    Browse the repository at this point in the history
  10. SOS-1272 IE7 bug on Tasks page

    ethib137 authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    c2692d0 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    a75c2ad View commit details
    Browse the repository at this point in the history
  12. SOS-1263 Source Formatting

    aarondelani authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    e27af34 View commit details
    Browse the repository at this point in the history
  13. SOS-1262

    - content of Welcome portlet on /home page of every SO site is copied during upgrade
    sustacek authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    3ea3691 View commit details
    Browse the repository at this point in the history
  14. SOS-1262 format-source

    johnnyhowey authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    fb1563c View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    1f66751 View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    4f99e7a View commit details
    Browse the repository at this point in the history
  17. LPS-30665 Apply to opensocial

    shinnlok authored and brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    94bab8a View commit details
    Browse the repository at this point in the history
  18. Revert "LPS-30665 Apply to opensocial"

    This reverts commit 94bab8a.
    brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    8e4d1bf View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    9e4ca4d View commit details
    Browse the repository at this point in the history
  20. SOS-1282

    - sidebar Sites fix for ie7
    sustacek committed Oct 30, 2012
    Copy the full SHA
    2b0e55a View commit details
    Browse the repository at this point in the history
  21. Source formatting

    brianchandotcom committed Oct 30, 2012
    Copy the full SHA
    577933e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2012

  1. SOS-1248 Revert fix

    ethib137 authored and U-LIFERAY-0POLKJU\Liferay committed Nov 16, 2012
    Copy the full SHA
    9cc1db8 View commit details
    Browse the repository at this point in the history