New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOS-1282 #214
SOS-1282 #214
Commits on Oct 17, 2012
-
LPS-30557 Deploy listener, set success response automatically
Ryan Park committedOct 17, 2012
Commits on Oct 18, 2012
Commits on Oct 19, 2012
Commits on Oct 20, 2012
-
SOS-1221 Reran ant "setup-eclipse" in so-hook and so-portlet because …
…the the "import.shared" in build.xml got moved from one plugin to the other
-
SOS-1221 Proper fix for changing logging level, otherwise, we will st…
…ill be printing out the messages. The way logging levels work. See logging hierarchy in http://logging.apache.org/log4j/1.2/manual.html. When you say that in the properties that you want to print DEBUG, then it will print DEBUG and everything lower than it. And INFO is lower than DEBUG, so it'll still print the messages. By switching the property to INFO, we will only print stuff lower than it, and DEBUG is higher than INFO, so no messages will get printed. The order is TRACE, DEBUG, INFO, WARN, ERROR, FATAL.
-
SOS-1221 Catch only the exception, and add a message. I think this is…
… what you wanted, can you double check the comment? Is that a true statement?
-
SOS-1221 I never (or rarely) use import .* in Java. I think it's a ba…
…d practice. In this case, if we import so.util.RoleConstants and not the portal one, we can use the RoleConstants.SOCIAL_OFFICE_USER
-
SOS-1221 1.) method names should start with a verb, so it is "cleanUp…
…SocialOffice" vs "socialOfficeCleanup". Methods take an action and do something. 2.) See updateGroups, I used the pattern of "for (int i = 0; i <= pages; i++) {", just search for Indexer.DEFAULT_INTERVAL in portal master. It prevents us loading EVERY community into memory. Imagine if there are 1 million. This allows us to paginate. 3.) I don't see the point of "updateUsers". When you delete the Social Office User role, the logic to trigger the RoleListener should already happen in "deleteSocialOfficeUserRole". But if you did need that logic, also use the pattern of "for (int i = 0; i <= pages; i++) {" or you will get slammed loading 1 million users from the db.
-
SOS-1248 Nothing happens after clicking on an announcement in the not…
…ifications portlet
-
-
-
Commits on Oct 22, 2012
-
-
-
-
-
-
LPS-30559 1.) Follow pattern in test-pacl/*/liferay-plugin-package.pr…
…operties for variable replacement 2.) only set the payload if there is a response
-
-
-
Commits on Oct 23, 2012
-
-
-
-
-
-
-
-
SOS-1254 Adding Keydown event to compensate for IE9 lack of support f…
…or property change.
-
-
-
Commits on Oct 24, 2012
-
-
-
-
LPS-30635 Migrate calendar to use Alloy Scheduler component with YUI …
…ModelList/Model support
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Oct 25, 2012
Commits on Oct 26, 2012
Commits on Oct 27, 2012
Commits on Oct 29, 2012
Commits on Oct 30, 2012
-
-
SOS-1264 IE7 borders missing or misaligned in contacts center, member…
…s, and messages pages
-
-
-
-
-
-
-
-
-
-
-
- content of Welcome portlet on /home page of every SO site is copied during upgrade
-
-
-
-
Revert "LPS-30665 Apply to opensocial"
This reverts commit 94bab8a.
-
-