Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Service Worker #394

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

ashawley
Copy link
Collaborator

This adds a very barebones service worker. Offline mode will be of some assistance to people who are on mobile.

The only assets we can guarantee exist on a PIxyll site are:

  1. the stylesheet and
  2. the home page.

Next steps could be adding the assets related to Google fonts, Font Awessome and MathJax. I had issues adding them, but I can loop back on it, or maybe someone can take a look.

Additional support for a Progressive web app could be added to Pixyll. A Jekyll site probably wouldn't be able to benefit from being a full Progressive web app, nor would it be worth the effort.

PS. The service worker will be disabled on pixyll.com because it's not HTTPS, so browsers will just ignore the service worker.

@ashawley
Copy link
Collaborator Author

ashawley commented Feb 13, 2019

Next steps could be adding the assets related to Google fonts, Font Awessome and MathJax. I had issues adding them, but I can loop back on it, or maybe someone can take a look.

Actually, I was able to solve this with the assistance of Jeff Posnick over on Stackoverflow.

Thank you, @jeffposnick. 🏆

@ashawley ashawley merged commit 333cb69 into johno:master Feb 14, 2019
@ashawley ashawley deleted the service-worker branch February 14, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant