Font size and spacing tweaks #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't add any new overrides for basscss.css definitions, just changed the existing ones. All changes made are calculated to have no visible effect at the current font sizes.
|
@WrinklyNinja is this the sizing/spacing you have on https://wrinklyninja.github.io/ ? |
| font-family: "Lato", 'Helvetica Neue', Helvetica, sans-serif; | ||
| font-weight: 900; | ||
| margin-top: 1rem; | ||
| line-height: 1.2; | ||
| margin: 1.414em 0 0.5em; |
There was a problem hiding this comment.
Looks like this line is missing a value: 1.414em 0 .5em 0?
There was a problem hiding this comment.
Either is valid: with 3 values, they correspond to top horizontal bottom. (From MDN)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #59. Two differences which I'll point out are that there is now more white space above post titles, and the heading sizes on mobile-sized screens have changed a bit.
Have a go with it though, and see if you like the changes.