Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure type scale consistency. #59

Closed
johno opened this issue Sep 2, 2014 · 4 comments
Closed

Ensure type scale consistency. #59

johno opened this issue Sep 2, 2014 · 4 comments
Assignees

Comments

@johno
Copy link
Owner

johno commented Sep 2, 2014

http://type-scale.com/
http://practicaltypography.com/

@johno johno self-assigned this Sep 2, 2014
@johno johno mentioned this issue Sep 2, 2014
@bandali0
Copy link
Contributor

bandali0 commented Sep 2, 2014

This would be extremely useful, especially because I plan to write my Résumé or CV using this theme (as a page).

@Ortham
Copy link
Contributor

Ortham commented Sep 11, 2014

I've got a fix for this (I basically just calculated the sizes from the ratios in your first link and your current <h1> sizes) in my site (which is based on Pixyll, thanks!). It's not live yet, but would you like a PR in the next few days?

I also converted all the spacing sizes you use to be ems instead of rems, so that they work better with font size changes. There's no visible difference to the current units, but should I separate that into a separate PR, or keep it all together?

@johno
Copy link
Owner Author

johno commented Sep 11, 2014

That's awesome. I'd love a PR. You could keep the two changes all together, however if the spacing change and font sizing change were two different commits, that would be perfect 😸.

Can't wait to see it. Thanks, @WrinklyNinja.

@johno
Copy link
Owner Author

johno commented Sep 11, 2014

Fixed with #68.

@johno johno closed this as completed Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants