Fix hidden responsive sidebar issue / Move X-UA-Compatible meta tag to be first #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
This PR addresses 2 issues.
Fix vanishing responsive sidebar
The responsive sidebar vanishes in these circumstances:
This happens because in the sidebar directive the
sidebar-inner
element gets set todisplay:none
as a result of the$sidebarInner.slideUp(350)
. This fix adds a single media query to force the visibility of thesidebar-inner
element when in desktop view.Preventing Compatibility-mode triggering in IE
I've noticed that the
<meta http-equiv="X-UA-Compatible" content="IE=edge, chrome=1" />
tag sits after a style tag in the template. This should mean that the tag will be ineffective - see MSDN:The simple fix is to amend the template from this:
To this:
ie. Simply moving the meta tag above the
<style
tag. It's a little thing, but if you've been bitten by Compatibility mode (I have 馃憥) it can be painful....Best,
John