Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example to the docs for how to implement a custom entity data service #151

Merged
merged 1 commit into from
May 18, 2018

Conversation

sstorie
Copy link
Contributor

@sstorie sstorie commented May 10, 2018

Adding an example for how to implement a custom entity data service

Purpose

This PR adds a simple example for how to create and register custom entity data services, which will be common in scenarios where people was to override the default behavior when retrieving and saving data.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

This is a result of the discussion in https://github.com/johnpapa/angular-ngrx-data/issues/143. It also seems that Prettier made some small updates to whitespace in certain parts of the document. I didn't change anything except to add the Further customization section at the end.

Adding an example for how to implement a custom entity data service
@wardbell
Copy link
Collaborator

Thank you! Merging. Then following up with sample update that essentially follows your example. I will tweak your prose to match the sample.

@wardbell wardbell merged commit b3d61c2 into johnpapa:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants