Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've added restart, min-seconds and set-seconds #19

Open
thommydz opened this issue Jul 7, 2016 · 3 comments
Open

I've added restart, min-seconds and set-seconds #19

thommydz opened this issue Jul 7, 2016 · 3 comments

Comments

@thommydz
Copy link

thommydz commented Jul 7, 2016

I really like this beautifull countdown and for most, it was what I was looking for for my project.

However I was missing some things.
I needed to be able to:

  • Remove seconds instead of adding seconds
  • Pause the countdown and restart it again
  • Let the user use an input area to set the seconds of the countdown

I managed to get all these options to work and I would love to share it here. However, I've never contributed anything on github so I don't really know how to do this.

If anyone is interested in the things I've added, please feel free to contact me!

@johnschult
Copy link
Owner

Create a pull request with your changes so we can review for merge 😃

—john

"If, after I depart this vale, you ever remember me and have thought to please my ghost, forgive some sinner and wink your eye at some homely girl." —H. L. Mencken

On Jul 7, 2016, 10:56 AM -0400, thommydznotifications@github.com, wrote:

I really like this beautifull countdown and for most, it was what I was looking for for my project.

However I was missing some things.
I needed to be able to:

Remove seconds instead of adding seconds
Pause the countdown and restart it again
Let the user use an input area to set the seconds of the countdown

I managed to get all these options to work and I would love to share it here. However, I've never contributed anything on github so I don't really know how to do this.

If anyone is interested in the things I've added, please feel free to contact me!


You are receiving this because you are subscribed to this thread.
Reply to this email directly,view it on GitHub(#19), ormute the thread(https://github.com/notifications/unsubscribe/AAAk7RLgv87SEdaYv537AGhveBwmMHCYks5qTRO2gaJpZM4JHKuy).

@meierz
Copy link

meierz commented Jul 10, 2019

Any News about this? The Restart Option would be a great thing!

@thommydz
Copy link
Author

I still have this code on my pc. I will create a pull request :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants