Problem with unicode characters #45
Comments
|
I was trying Bulgarian characters (like: А, Б, В, Г, Д....) and everything works with Nginx backned under Python 3. Can you investigate where exactly the things get broken. |
|
I suspect it's more to do with how the default encoding on the server is setup etc. |
|
It could be related with server encoding, I don't remember right now and I can't tested, sorry. |
|
The problem is that the URL that's handed to nginx via the X-Accel-Redirect header isn't quoted. If you use urllib.parse.quote() on the URL there're no problem. |
|
Possibly. I started a new job 3 months ago and it's been pretty intense... |
|
@lilspikey that's not much to go on. What would it take for you to review a PR? |
|
I have a suggestion for generating the value for We can have a And then calculating the internal URL will be just: I think that this will solve the problem with the encoding. For more info https://docs.djangoproject.com/en/1.9/ref/files/storage/#the-filesystemstorage-class |
|
@Proper-Job hopefully I could review it in July. If it's just the quoting, then it shouldn't be a large change, so should manage it. New job doesn't involve Django at all, so this would purely be done in personal time. @vstoykov that looks like it might work, but for the sake of a small change it might be easier to just go with adding quoting for now. |
|
I created a PR for this issue. I successfully tested it on nginx. #54 |
|
Note that escaped URIs breaks support for Nginx versions older than 1.5.9 which isn't expecting them in the X-Accel-Redirect header. I personally think this is fine seeming as it's either not-supporting a 3-year-old release of Nginx or not-supporting unicode file names. But I'm leaving this as a note for anyone noticing the breakage when upgrading sendfile. |
In this commit we are adding support for Nginx version older than 1.5.9. This is achieved through conditionally quoting the URL's in X-Accel-Redirect headers according to compatibility with Nginx. Since newer versions of Nginx expect URL's in X-Accel-Redirect to be quoted unlike the versions older that Nginx 1.5.9. In this commit we start to check the Nginx version using 'nginx -v' and then caching the result be making use of a decorator. Using this result we decide whether the outgoing URL should be quoted or not. Fixes: johnsensible#56, johnsensible#58. Closes johnsensible#45.
In this commit we are adding support for Nginx version older than 1.5.9. This is achieved through conditionally quoting the URL's in X-Accel-Redirect headers according to compatibility with Nginx. Since newer versions of Nginx expect URL's in X-Accel-Redirect to be quoted unlike the versions older that Nginx 1.5.9. In this commit we start to check the Nginx version using 'nginx -v' and then caching the result be making use of a decorator. Using this result we decide whether the outgoing URL should be quoted or not. Fixes: johnsensible#56, johnsensible#58. Closes johnsensible#45.
In this commit we are adding support for Nginx version older than 1.5.9. This is achieved through conditionally quoting the URL's in X-Accel-Redirect headers according to compatibility with Nginx. Since newer versions of Nginx expect URL's in X-Accel-Redirect to be quoted unlike the versions older that Nginx 1.5.9. From this commit onwards we start to expect a 'NGINX_VERSION' config setting to be setup in the django settings in order to facilitate decision making regarding quoting URL's. If such a setting is not found we just assume Nginx version to be greater then 1.5.9 and make decision accordingly and then cache the decision by making use of a decorator. Using this result we decide whether the outgoing URL should be quoted or not. Fixes: johnsensible#56, johnsensible#58. Closes johnsensible#45.
In this commit we are adding support for Nginx version older than 1.5.9. This is achieved through conditionally quoting the URL's in X-Accel-Redirect headers according to compatibility with Nginx. Since newer versions of Nginx expect URL's in X-Accel-Redirect to be quoted unlike the versions older that Nginx 1.5.9. From this commit onwards we start to expect a 'NGINX_VERSION' config setting to be setup in the django settings in order to facilitate decision making regarding quoting URL's. If such a setting is not found we just assume Nginx version to be greater then 1.5.9 and make decision accordingly and then cache the decision by making use of a decorator. Using this result we decide whether the outgoing URL should be quoted or not. Fixes: johnsensible#56, johnsensible#58. Closes johnsensible#45.
In this commit we are adding support for Nginx version older than 1.5.9. This is achieved through conditionally quoting the URL's in X-Accel-Redirect headers according to compatibility with Nginx. Since newer versions of Nginx expect URL's in X-Accel-Redirect to be quoted unlike the versions older that Nginx 1.5.9. From this commit onwards we start to expect a 'NGINX_VERSION' config setting to be setup in the django settings in order to facilitate decision making regarding quoting URL's. If such a setting is not found we just assume Nginx version to be greater then 1.5.9 and make decision accordingly and then cache the decision by making use of a decorator. Using this result we decide whether the outgoing URL should be quoted or not. Fixes: johnsensible#56, johnsensible#58. Closes johnsensible#45.
When I try to set up to sendfile with spanish characters (like: á, é, í, ó, ú...) using nginx backend, the link of sendfile response its: 404 not found.
The text was updated successfully, but these errors were encountered: