Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_data
function is small enough that it didn't take too long to understand what it's doing. However, there are several changes that should make it much clearer for future review/maintenance.thefile --> filename
to clarify that it's a file name, rather than an already-opened file handleposition_reads --> run_index
andread_type --> run_acc
: the original variable names were unclear at best, and potentially misleading at worst. Made it more difficult to understand the purpose of the code.