Feat/component scaffolder #2096
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the JNJ Demo Account Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -23,8 +23,8 @@ import { | |||
| const prompts: Prompts = [ | |||
| { | |||
| type: 'input', | |||
| name: 'packageSourcePath', | |||
| message: `Path to package source(src) directory [Required], | |||
| name: 'destinationpath', | |||
There was a problem hiding this comment.
destinationpath => destinationPath?
There was a problem hiding this comment.
no - i chose this bc it is the name used by https://github.com/SamKirkland/plop-templates. If you adopt a different vs-code integration, we may change it again.
| * @category Token Collection | ||
| * @see [[{{properCase componentName}}Clean]] | ||
| */ | ||
| export interface {{properCase libraryName}}{{properCase componentName}} { |
There was a problem hiding this comment.
extends DesignableComponents?
There was a problem hiding this comment.
no it's a token collectionm, not a set of components.
There was a problem hiding this comment.
sorry, I mean for export type {{properCase componentName}}Components:
export type {{properCase componentName}}Components extends DesignableComponents = {
| validate: componentNameValidator, | ||
| }, | ||
| { | ||
| type: 'input', | ||
| name: 'libraryName', | ||
| message: 'Name of the library [Required]', | ||
| message: 'library name (eg. brand) [Required]', |
There was a problem hiding this comment.
library => Library
(eg. myBrand)?
| @@ -42,6 +42,7 @@ | |||
| "pw:run": "npx playwright test playwright/tests/smoke-deprecated/* --project=chromium --workers 1", | |||
| "playwright:run": "npx playwright test playwright/tests/smoke/* --project=chromium --workers 3", | |||
| "psh:setup-starter": "node ./scripts/psh-setup-starter", | |||
| "scaffold": "plop --plopfile packages/bodiless-scaffold/lib/config/component.js", | |||
There was a problem hiding this comment.
how about
"scaffold": "cd packages/bodiless-scaffold && npm run scaffold",
There was a problem hiding this comment.
this was set up as the command used by https://github.com/SamKirkland/plop-templates. Anyway, using cd... won't work in case you specify the destinationpath on the cli as a relative path. I'd just remove this for now and come up with a better way of running it in scope of the repo refactor
dewen
merged commit afc59db
into
johnsonandjohnson:feat/component-scaffolder
Changes
Test Instructions
Related Issues