Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final package declaration fix #25

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Final package declaration fix #25

merged 1 commit into from
Nov 1, 2018

Conversation

flogy
Copy link
Contributor

@flogy flogy commented Oct 31, 2018

As mentioned in #22 there is still an issue with the package declaration inside the two Java classes. They are in the correct folder structure as defined in the AndroidManifest.xml but the package declaration still is incorrect.

This pull request should finally fix the issue.

@flogy flogy mentioned this pull request Oct 31, 2018
Copy link
Owner

@johnsonsu johnsonsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thank you!💯

@johnsonsu johnsonsu merged commit 68bfc65 into johnsonsu:master Nov 1, 2018
@flogy flogy deleted the package-declaration-fix branch November 1, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants