Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RN >= 0.60 auto linking for ios #71

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

mstrk
Copy link
Contributor

@mstrk mstrk commented Aug 18, 2019

This should fix the auto link in ios.

NOTE:
From now on, all version releases should have a tag, or the pod installed will default to master.
tag pattern is based on your current tags -> x.x.x

If react-native-sound-player was already linked in the project one must unlink it. Maybe it's a good thing aware people in the README.md. (Not done in this PR)

fixes #70, closes #68

@SamyBrom
Copy link

Tested RN 0.60.4, works

@johnsonsu johnsonsu merged commit c08f9e6 into johnsonsu:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Native module cannot be null" no podspec found for react-native-sound-player
3 participants