Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support removing more than one pane at a time #320

Conversation

johnwalley
Copy link
Owner

No description provided.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for allotment-storybook ready!

Name Link
🔨 Latest commit 0513d69
🔍 Latest deploy log https://app.netlify.com/sites/allotment-storybook/deploys/629d1c2e8fb26300088c1e8c
😎 Deploy Preview https://deploy-preview-320--allotment-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for allotment-website canceled.

Name Link
🔨 Latest commit 0513d69
🔍 Latest deploy log https://app.netlify.com/sites/allotment-website/deploys/629d1c2e68753b0008082302

Copy link
Contributor

@Gelio Gelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run the code, but I believe is the approach to fix #314. Thanks 👌

@johnwalley johnwalley merged commit 8b3b444 into main Jun 6, 2022
@johnwalley johnwalley deleted the 314-removing-multiple-panes-during-a-rerender-causes-a-runtime-error branch June 6, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing multiple panes during a rerender causes a runtime error
2 participants