Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R7RS errata with three minor fixes to formal semantics, close … #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenganz
Copy link

#39 and close #40.

Copy link

@ashinn ashinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but overall LGTM, thanks for working on this!

@@ -151,3 +151,9 @@ apply only to *non-ASCII* characters; the valid ASCII characters are given expli
31\. In section 1.1, the sentence "Each use of a variable is associated with a lexically apparent binding of that variable" appears. However, this is only true after macroexpansion, as the binding may be hidden in a user-written macro. Prefix the sentence with "After macros are expanded".

32\. In the third paragraph of the definition of `null-environment`, the reference to `scheme-report-environment` should be to `null-environment`, and is changed accordingly.

33\. In the definition of `car-internal` in the formal semantics, the ω parameter should be dropped.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the formal semantics was updated to support dynamic-wind, it does not include exception handling (arguably derivable) introduced in R7RS. If we were to later add this, it might be more correct to pass omega through to car-internal, in consideration of implementations which signal an error here (not required).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, the type of car-internal will need a fix instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error of cwv in R7RS-small 7.2.4
3 participants