Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying a list of songs instead of lyrics. #117

Closed
Qiasm opened this issue Oct 20, 2019 · 10 comments
Closed

Displaying a list of songs instead of lyrics. #117

Qiasm opened this issue Oct 20, 2019 · 10 comments
Labels

Comments

@Qiasm
Copy link

Qiasm commented Oct 20, 2019

Describe the bug
When I search for the lyrics of a song it shows me a list of different songs on genius but no the lyrics of the song I specified. I'm using the search_song() function. The title of the song is without any "remix", "live" etc. tags.

Expected behavior
It should be displaying the lyrics of the song not a list of different songs grabbed from genius.

To Reproduce
Describe the steps required to reproduce the behavior.

  1. Search for the song "Post Malone (feat. RANI) by Sam Feldt. genius.search_song("Post Malone (feat. RANI)", "Sam Feldt"
  2. Print the results.
  3. It should be displaying a list of different songs but not lyrics.

I get no error just the behavior of the module is wrong.

Version info

  • Package version [1.7.0]
  • OS: [Windows 10 Home 64-bit]

Additional context
It's not happening to every song. Just a few songs have this problem.

@johnwmillr
Copy link
Owner

@Qiasm I don't understand the problem you're describing. The package is returning the top song result for your query. You want a list of song options instead of picking the top song?

@Qiasm
Copy link
Author

Qiasm commented Nov 9, 2019 via email

@johnwmillr
Copy link
Owner

Try this:

song = genius.search_song("Post Malone (feat. RANI)", "Sam Feldt")
print(song.lyrics)

@Qiasm
Copy link
Author

Qiasm commented Nov 10, 2019 via email

@johnwmillr
Copy link
Owner

Your image didn’t come through. The lyrics are included with each song that is returned from the search.

When I search for the Post Malone example above, I get the correct song. Can you give an example of the incorrect results?

@Qiasm
Copy link
Author

Qiasm commented Nov 10, 2019 via email

@johnwmillr
Copy link
Owner

Still no image. Can you paste the text you're searching for and the output text?

@Qiasm
Copy link
Author

Qiasm commented Nov 14, 2019 via email

@allerter
Copy link
Collaborator

allerter commented Sep 6, 2020

Closing this as it seems the issue has been solved since there's been no activity.

@ncchen55414
Copy link

I'm having the same issue . 'song.lyrics' does not return the lyrics, but return a list of songs instead. (screenshot attached)

song = genius.search_song("Post Malone (feat. RANI)", "Sam Feldt")
print(song.lyrics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants