Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly get_full_info for songs and albums #181

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Properly get_full_info for songs and albums #181

wants to merge 14 commits into from

Commits on Feb 10, 2021

  1. 🔧 Properly get full song info 

    Previously, it was fetched only when the song didn't have an id (?)
    @Steffo99
    Steffo99 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4f64207 View commit details
    Browse the repository at this point in the history

  2. 🔧 Add fields in song for the new fields

    @Steffo99
    Steffo99 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    bb948b1 View commit details
    Browse the repository at this point in the history

  3. 🔧 Keep the statement as it is, but move it before song_id is overwrit… 

    …ten in both search_song and search_album
    @Steffo99
    Steffo99 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f67f429 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Revert "🔧 Add fields in song for the new fields" 

    This reverts commit bb948b1
    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    e8debe1 View commit details
    Browse the repository at this point in the history

  2. 🔧 Fix get_full_info logic

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    16c0b29 View commit details
    Browse the repository at this point in the history

  3. 🐛 Set search_term for both types of album queries, preventing a Nam… 

    …eError
    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    975326f View commit details
    Browse the repository at this point in the history

  4. 🐛 Set search_term for both types of song queries, preventing a Name… 

    …Error
    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    8b844ff View commit details
    Browse the repository at this point in the history

  5. ✏ Rename result to song_info to avoid defining song_info later

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    5bae548 View commit details
    Browse the repository at this point in the history

  6. 🤦 Oops. Now album_info was always None. 

    Please squash this commit! :)
    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    aa6f725 View commit details
    Browse the repository at this point in the history

  7. 🧹 Reindent due to variable rename

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    a2ba056 View commit details
    Browse the repository at this point in the history

  8. 🔧 Fix get_full_info logic for song searches

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    7edbe43 View commit details
    Browse the repository at this point in the history

  9. 🐛 Remove quotes from the search_term in album

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    90d6a41 View commit details
    Browse the repository at this point in the history

  10. 🐛 Remove quotes from the search_term in song

    @Steffo99
    Steffo99 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    f774e73 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. 🔧 Change .get("album") to ["album"]

    @Steffo99
    Steffo99 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    63df8df View commit details
    Browse the repository at this point in the history