-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when album contains only year information #182
Conversation
Hi. Thanks for your PR. I think it's good to go. |
Looking at the Album attributes got me thinking. The album dict already has a
|
I'm not familiar with the internals of this module, I simply got this exception and applied a quick fix. |
Don't mind that comment. It's just meant for the developers. Your PR is good to go and it'll probably be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @gal20! I'll merge your changes now.
Tested with Hadestown (2010).
On master, I get the following exception:
The error is caused by this line:
date = int(year)
when
date
should be a string.I've fixed this issue and simplified the function a bit.