fix capturing audio bug for yahoo dictionary. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I did ignore some online dictionaries because of the same reason that Yahoo dictionary currently behaves. Because keep retrying to get DOMs that may or may not exist seems like a hack to me. I believe there might be an Event-Driven or Async/Await Promise solution out there in the Chrome Extension API/architecture. But sadly I don't have time to dive into the documents. Anyway, thanks for the fix. Really appreciate it. ❤️ p.s. Please make changes in your own branch(e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem that we can't get the audio element is because Yahoo dictionary would generate audio elements later after we tried to get them.
Therefore, we could retry to get the element later, also add the maximum retry constraint in order to avoid infinite retry.