Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript - update alwaysFetch to accept array #465

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Typescript - update alwaysFetch to accept array #465

merged 1 commit into from
Jan 17, 2022

Conversation

danieljvdm
Copy link
Contributor

The alwaysFetch param is treated as an array or string in the actual code base (and in the docs) but typescript complains when passing in an array

@danieljvdm
Typescript - update alwaysFetch to accept array
03ed70b 
The alwaysFetch param is treated as an array or string in the actual code base (and in the docs) but typescript complains when passing in an array
alexbbt
alexbbt approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@alexbbt alexbbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing!

@airhorns airhorns merged commit 00790e5 into join-monster:master Jan 17, 2022
@lorensr
Copy link
Member

lorensr commented Jan 17, 2022

🙏 published in 3.1.0 https://github.com/join-monster/join-monster/blob/master/docs/CHANGELOG.md#v310-january-17-2022-

@danieljvdm danieljvdm deleted the patch-1 branch June 24, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbbt alexbbt alexbbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieljvdm @lorensr @alexbbt @airhorns