Responding to Audit Finding 3.22 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickreynolds
commented
Jul 12, 2018
nickreynolds
commented
- Use Latest Standard version of PLCRVoting and extend it rather than Copying + Modifying
- also moving contracts around to clean up our EPM + NPM installed contracts
- changes to AddressRegistry are temporary as it will be replaced with Standard implementation soon
…opying + Modifying lower solidity version fix migration rearranging contracts move contracts again update readme
Pull Request Test Coverage Report for Build 5505
💛 - Coveralls |
…of copying + modifying
…ool for challenge
…, to match standard implementation
Respond to Audit Finding 3.38
Responding to Audit Finding 3.36
Respond to Audit Finding 3.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.