Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responding to Audit Finding 3.36 #275

Merged
merged 5 commits into from
Jul 17, 2018
Merged

Responding to Audit Finding 3.36 #275

merged 5 commits into from
Jul 17, 2018

Conversation

nickreynolds
Copy link
Member

  • tiny gas savings in CivilTCR
  • using safemath when calculating rewardPool for challenge

@nickreynolds nickreynolds requested a review from suhabe July 17, 2018 19:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5494

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 87.988%
Totals Coverage Status
Change from base Build 5475: -0.09%
Covered Lines: 406
Relevant Lines: 444
💛 - Coveralls

@nickreynolds nickreynolds merged commit 38d3d72 into nickreynolds/audit-3-21 Jul 17, 2018
@dankins dankins deleted the nickreynolds/audit-3-36 branch July 27, 2018 00:52
@ajesse11x ajesse11x mentioned this pull request Aug 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhabe suhabe suhabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickreynolds @coveralls @suhabe