Pre-populate logo and newsroom URL from props if available #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobek
changed the base branch from
tobek/ch2449/send-in-save-load-data-from-cms-for-charter-roster-ui
to
master
walfly
suggested changes
Oct 12, 2018
| @@ -108,30 +117,29 @@ class CreateCharterPartOneComponent extends React.Component<CreateCharterPartOne | |||
| Logo | |||
| <QuestionToolTip | |||
| explainerText={ | |||
| "You need to add a URL to a logo or image. You can add a logo to your WordPress media library and copy the URL here. We recommend the image dimensions to be at minimum 300 x 300 pixels." | |||
| /*"You need to add a URL to a logo or image. You can add a logo to your WordPress media library and copy the URL here. We recommend the image be square and at minimum 300 x 300 pixels."*/ | |||
| } | ||
| /> | ||
| </FormSubhead> | ||
| <LogoFormWrap> | ||
| <LogoURLWrap> | ||
| <LogoURLInput | ||
| placeholder="Enter URL or Open Media Library" | ||
| /*placeholder="Enter URL or Open Media Library"*/ |
| noLabel | ||
| name="logoUrl" | ||
| value={this.props.charter.logoUrl || ""} | ||
| onChange={this.charterInputChange} | ||
| /> | ||
| </LogoURLWrap> | ||
| <TertiaryButton size={buttonSizes.SMALL}>Open Media Library</TertiaryButton> | ||
| <LogoImgWrap>{this.props.charter.logoUrl && <LogoImg src={this.props.charter.logoUrl} />}</LogoImgWrap> | ||
| {/*<TertiaryButton size={buttonSizes.SMALL}>Open Media Library</TertiaryButton>*/} |
|
@walfly the designs called for a "upload logo to WP Media Library" button that it's not worth implementing before launch, but I had partially implemented it. Was just going to leave the markup in for when we do later. There's also a bunch of styles for it. But yeah I'll remove it all, I can always blame my way to this commit if I want to get it back. Actually will link this PR to the ticket for implementing it. |
…n-newsroom-logo-and-url-from-wp-into-manager
|
@walfly updated |
…-from-wp-into-manager
walfly
approved these changes
Oct 15, 2018
tobek
deleted the
tobek/ch2452/pass-in-newsroom-logo-and-url-from-wp-into-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace un-implemented CMS media library for logo with just an img tag