Enable github login #419
Closed
Enable github login #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a button and the call to the API to enable github users to register or login without an account here
|
Can one of the admins verify this patch? |
|
ok to test |
|
Thanks for this @exussum12 - I'm waiting for joindin/joindin-api#424 to be sorted before I merge anything else that relies on the API as that PR touches lots of files, but as soon as that's through I'll look at this |
|
I am going to update this to be id based instead of email so will need a little extra time either way |
|
Closing as we've also put on hold adding providers until we clean up the oauth code we're using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a button and the call to the API to enable github users to register
or login without an account here