Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom tx fee on direct-send #696

Closed
theborakompanioni opened this issue Nov 25, 2023 · 2 comments · Fixed by #706
Closed

feat: custom tx fee on direct-send #696

theborakompanioni opened this issue Nov 25, 2023 · 2 comments · Fixed by #706
Assignees
Labels
enhancement New feature or request

Comments

@theborakompanioni
Copy link
Collaborator

Since JoinMarket-Org/joinmarket-clientserver#1597 it is possible to specify the txfee directly on direct-send operations.

Note: This feature must be hidden behind a version flag as it will only be available with backend version >= 0.9.11.

As a user, I want to specify a custom tx fee when creating a single transaction, so I not have to edit the config values on a per transaction basis. This can be done by adding a custom tx input field, prefilled with the config value, to the send options on non-collaborative sends.

Later, this functionality can be used when creating/unlocking/renewing fidelity bonds (#678).

@kristapsk
Copy link
Contributor

From Jam UX perspective, if custom fee can be specified for direct-send, wouldn't you like to have it also for /wallet/{walletname}/taker/coinjoin? Implementation should not be hard, scripts/sendpayment.py already support it for both coinjoin and non-coinjoin sends.

@theborakompanioni
Copy link
Collaborator Author

From Jam UX perspective, if custom fee can be specified for direct-send, wouldn't you like to have it also for /wallet/{walletname}/taker/coinjoin? Implementation should not be hard, scripts/sendpayment.py already support it for both coinjoin and non-coinjoin sends.

That would indeed be awesome. 🚀
Thanks @kristapsk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants