Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional txfee property for direct-send wallet RPC #1597

Merged

Conversation

kristapsk
Copy link
Member

Resolves #1360. Jam wants it for joinmarket-webui/jam#678.

@kristapsk
Copy link
Member Author

@theborakompanioni Please test. I only checked that this doesn't break wallet RPC tests, which covers only existing scenario with no custom tx fee specified. Two things should be tested: 1) that tx fee is actually changed, 2) that it's not changed permanently in backend and is reverted to config defaults after tx is made.

@kristapsk kristapsk changed the title Add optional txfee property for direct-send wallet RPC Add optional txfee property for direct-send wallet RPC Nov 16, 2023
@theborakompanioni
Copy link
Contributor

@theborakompanioni Please test. I only checked that this doesn't break wallet RPC tests, which covers only existing scenario with no custom tx fee specified. Two things should be tested: 1) that tx fee is actually changed, 2) that it's not changed permanently in backend and is reverted to config defaults after tx is made.

I'll still need some time to provide proper feedback, but my early tests were successful. So nice!
Will let you know as soon as possible. Thanks @kristapsk 🙏

src/jmclient/wallet_rpc.py Outdated Show resolved Hide resolved
@AdamISZ
Copy link
Member

AdamISZ commented Nov 18, 2023

Thanks for the patch @kristapsk , it's not difficult to imagine why it is wanted (given config edits are janky).

@kristapsk
Copy link
Member Author

Addressed review comments.

@AdamISZ
Copy link
Member

AdamISZ commented Nov 21, 2023

tACK d8f1fc4

(this is a bit naughty, I did not test that, but the previous commit, but the only difference is a single str() cast to correct the error, so I don't think it's so bad...)

@kristapsk kristapsk merged commit 8e27120 into JoinMarket-Org:master Nov 22, 2023
8 checks passed
@kristapsk kristapsk deleted the wallet_rpc-direct-send-txfee branch November 22, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: provide tx fee in direct-send api request
3 participants