-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional txfee
property for direct-send
wallet RPC
#1597
Add optional txfee
property for direct-send
wallet RPC
#1597
Conversation
@theborakompanioni Please test. I only checked that this doesn't break wallet RPC tests, which covers only existing scenario with no custom tx fee specified. Two things should be tested: 1) that tx fee is actually changed, 2) that it's not changed permanently in backend and is reverted to config defaults after tx is made. |
txfee
property for direct-send
wallet RPC
I'll still need some time to provide proper feedback, but my early tests were successful. So nice! |
Thanks for the patch @kristapsk , it's not difficult to imagine why it is wanted (given config edits are janky). |
5bed40f
to
d8f1fc4
Compare
Addressed review comments. |
tACK d8f1fc4 (this is a bit naughty, I did not test that, but the previous commit, but the only difference is a single |
Resolves #1360. Jam wants it for joinmarket-webui/jam#678.