Merge pull request #341 from joke2k/fix/pymemcached-url-parsing

Fix memcache/pymemcache URL parsing

CHANGELOG.rst

@@ -11,6 +11,8 @@ Fixed
 +++++
 - Fixed "Invalid line" spam logs on blank lines in env file
   `#340 <https://github.com/joke2k/django-environ/issues/340>`_.
+- Fixed ``memcache``/``pymemcache`` URL parsing for correct identification of
+  connection type `#337 <https://github.com/joke2k/django-environ/issues/337>`_.
 
 
 `v0.8.0`_ - 17-October-2021

environ/environ.py

@@ -584,7 +584,15 @@ def cache_url_config(cls, url, backend=None):
                 'LOCATION': url.netloc + url.path,
             })
 
-        if url.path and url.scheme in ['memcache', 'pymemcache']:
+        # urlparse('pymemcache://127.0.0.1:11211')
+        # => netloc='127.0.0.1:11211', path=''
+        #
+        # urlparse('pymemcache://memcached:11211/?key_prefix=ci')
+        # => netloc='memcached:11211', path='/'
+        #
+        # urlparse('memcache:///tmp/memcached.sock')
+        # => netloc='', path='/tmp/memcached.sock'
+        if not url.netloc and url.scheme in ['memcache', 'pymemcache']:
             config.update({
                 'LOCATION': 'unix:' + url.path,
             })

tests/test_cache.py

@@ -68,6 +68,9 @@ def test_base_options_parsing():
         ('pymemcache://127.0.0.1:11211',
          PYMEMCACHE_DRIVER,
          '127.0.0.1:11211'),
+        ('pymemcache://memcached:11211/?key_prefix=ci',
+         PYMEMCACHE_DRIVER,
+         'memcached:11211'),
     ],
     ids=[
         'dbcache',
@@ -84,6 +87,7 @@ def test_base_options_parsing():
         'memcached_multiple',
         'memcached',
         'pylibmccache',
+        'pylibmccache_trailing_slash',
     ],
 )
 def test_cache_parsing(url, backend, location):