Update SQL Server engine as mssql-django #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
added
enhancement
|
@rcy17 Could you please update tests in |
|
Sorry for ignoring the tests. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #295 , mssql-django is an official django-mssql-backend port by Microsoft in the making. Besides, this package is also the only backend mentioned in django docuent for SQL Server ( https://docs.djangoproject.com/en/4.1/ref/databases/#using-a-3rd-party-database-backend ) .
Based on the document of
mssql-django, the name of name should bemssql, so I changed it.BTW, it's my regret to get known to
django-environso late, before which I was always struggling with a mess of varaibles in.envlike "MYSQL_USER", "MYSQL_PASSWD", "DATABASE_ENGINE" to manage the different database between development and production environment. Thank you!