Fix #1051 #1087
Merged
Fix #1051 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! ✨ |
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* add .python-version to .gitignore (pyenv virtualenv file) * rename country_code to area_code as it conflicts with address provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Fixes #1051
This also adds an entry to .gitignore for pyenv users who take advantage of
pyenv-virtualenvWhat was wrong
The use of method name
country_codeinfaker/providers/phone_number/ar_PS/__init__.pywas overriding the functionality ofaddress.country_codewhen localear_PSis specified.How this fixes it
Renaming to
area_coderemoves the conflict, causing the error seen in #1051, while ensuring that all phone_number localization forar_PScontinues to work.Fixes #1051