-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Network tree - node content overflows the node box if less than 35 devices #465
Comments
Hi there, Can you please send me the browser you are using? Are you zoomed in/out? I checked on my end and it works fine on Firefox, Edge, Chrome. Try also clearing cache and cookies. If issues persist, can you please send me a screenshot of the inspector in your browser of one of the nodes with the css visible? Thanks, |
I'm having this same issue. There are two icons being listed and there is not enough room for both of them. It looks like the problem is here: jokob-sk/Pi.Alert@7efe658#diff-e2a70fa8ded4064777a348b63e9bb6f99b064229bc37d02374ca4346ae8c4144L649-R653 I can't tell what the intended behavior is, but the markup and css are not leaving enough room. |
Regrettably, I still can't reproduce the issue, even on a Could you please verify you are on the latest release? Here are the on-the-fly calculated values for a screen resolution of Thanks in advance, |
I've just compared my front/network.php and the one in the repo and they match. Also in https://github.com/jokob-sk/Pi.Alert/issues/424 (previous version) boxes were not rounded as in latest version. |
Just tried 1920x1080p screen,same thing. Like the box is split into 2 lines, with 2 icons in first one, and text in second one, |
Hummm. |
@jokob-sk It looks like this isn't happening to you because of how many leaf nodes you have in your network diagram. In your markup the dimensions are If you add the following styles to chrome you can see it how we do:
It seems like any leaf node count below ~35 will present this way if I am not mistaken. |
Thanks @ScottRoach! |
I have 34 devices :) |
@vladaurosh you are right. I was confused because of the default 2.7em size. It seems like it values are not calculated as per above js code. Are there any js errors in the dev console? |
@ScottRoach the issue seems to be that the quoted code is not executed on your instance, not the device count. |
I'm not sure what you mean by this. I have breakpoints on the code that I referenced above and am certain that it is running. If I manipulate the Screen.Recording.2023-10-03.at.2.42.13.PM.mp4 |
@ScottRoach this helped a lot, thanks! I pushed a fix - if anyone can test the Thanks in advance, |
@lorki97 this is intended. I'll leave it for now and if someone wants to submit a PR I can review it and approve. I'm really not a front end expert 😅 |
This looks much better on the dev container. I will try to make a PR to space out the icons and center align the port number (if set). For now though this is much better! Thanks! |
Thanks in advance @ScottRoach 🙏 |
Released in 23.11.11 |
Describe the issue
Just updated from 23.7.22 to latest and there are some visual bugs.
Network diagram looks really bad.
New look:
Previous look:
Then trying to change device type opens blank drop down.
The text was updated successfully, but these errors were encountered: