Show current device icon as it changes #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the current device icon on the device detail page and also shows it change as you type/select a different icon.
Is your feature request related to a problem? Please describe.
Not being able to see the current icon (visually) associated with a device on the detail page is a little frustrating. It would also be nice to be able to try some different phrases to see if an icon exists (ex:
lightdoesn't work bylightbulbdoes).Describe the solution you'd like
The icon is displayed next to the text and changes in real time as you type
Describe alternatives you've considered
To find a new icon I would manually going to the font awesome search form. To see the way the current icon looks I would go back to the device list and view it there.
Additional Context
There was not much room with all the existing extra input addons so I removed all of the pencil icons which just focused the input field which felt redundant to just clicking into the field.
Screenshot
Sample interaction
https://github.com/jokob-sk/Pi.Alert/assets/970677/8189ba7d-f483-461f-9108-cb62dfbb2796