Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation #72

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fix deprecation #72

merged 1 commit into from
Dec 2, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Dec 1, 2021

No description provided.

@lyrixx lyrixx force-pushed the depre branch 2 times, most recently from 8dae385 to 29295c4 Compare December 1, 2021 15:43
@lyrixx lyrixx changed the title Fix Symfony deprecation (and forbid SF6.0) Fix Symfony deprecation Dec 1, 2021
@lyrixx lyrixx force-pushed the depre branch 2 times, most recently from efacf5a to 56a616c Compare December 1, 2021 15:50
@lyrixx
Copy link
Member Author

lyrixx commented Dec 1, 2021

There is a deprecation:

Remaining indirect deprecation notices (1)

  1x: Method "FilterIterator::accept()" might add "bool" as a native return type declaration in the future. Do the same in child class "SebastianBergmann\FileIterator\Iterator" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in FunctionalTest::testRenderTwigViaFilter from JoliTypo\Tests\Bridge

But I really don't know how to fix it. It seems to be in phpunit: https://github.com/sebastianbergmann/php-file-iterator/blob/2.0.4/src/Iterator.php#L56

@lyrixx lyrixx mentioned this pull request Dec 1, 2021
Merged
lyrixx added a commit that referenced this pull request Dec 1, 2021
@lyrixx
Temporary forbid support for symfony/error-handler
4b362fc 
This mitigate the following deprecation #72 (comment)
This could be reverted once sebastianbergmann/php-file-iterator#74
is merged and released.

Note that this does not forbid the component in version 6, but in this
case, PHP 8.0 is required, and so the attribute is not ignored.
@lyrixx lyrixx changed the title Fix Symfony deprecation Fix deprecation Dec 2, 2021
@lyrixx lyrixx merged commit 91292f0 into master Dec 2, 2021
@lyrixx lyrixx deleted the depre branch December 2, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lyrixx