Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issue with Windows #374

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 3, 2024

fix #339
fix #342

@lyrixx lyrixx force-pushed the windows-and-tty-are-in-speedboat branch from 5feb2c3 to 48d1a23 Compare April 3, 2024 12:55
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
examples/run.php Outdated Show resolved Hide resolved
src/functions.php Outdated Show resolved Hide resolved
@lyrixx lyrixx force-pushed the windows-and-tty-are-in-speedboat branch from cd2651a to 76b579f Compare April 3, 2024 14:23
@lyrixx lyrixx force-pushed the windows-and-tty-are-in-speedboat branch from 76b579f to 45424c4 Compare April 3, 2024 14:25
@lyrixx lyrixx requested a review from pyrech April 3, 2024 14:25
@TheoD02
Copy link
Contributor

TheoD02 commented Apr 3, 2024

What about adding an CI check on a Windows machine? (macOS can be interesting too)

This would ensure that the castor is working properly?

@lyrixx
Copy link
Member Author

lyrixx commented Apr 3, 2024

It would be nice indeed

Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@pyrech pyrech merged commit b13c34d into main Apr 3, 2024
9 checks passed
@pyrech pyrech deleted the windows-and-tty-are-in-speedboat branch April 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When exit_code or run is invoked, the task does not complete (fwrite() error)
3 participants