-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change the behavior of notify
parameter in context to default to null by default
#449
fix: Change the behavior of notify
parameter in context to default to null by default
#449
Conversation
bfa1f2e
to
c883238
Compare
Feedbacks fixed 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small typo but LGTM
…to null by default
c883238
to
3b09fbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
The changes allow the
notify
property in the context to be set tonull
and this is the new default value.Previously, the
notify
property could only be set totrue
orfalse
. Now, it can be set tonull
,true
, orfalse
.Here's what each value means:
false
: Notifications are disabled globally.null
: Notifications are disabled for internal Castorrun
,with
calls, butnotify()
calls triggered by the user will still show notifications.true
: All notifications will be shown.This change provides more flexibility for controlling when notifications are shown.
Changes
Resolve #444