Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate stubs in same location where castor.php is located by default #457

Conversation

TheoD02
Copy link
Contributor

@TheoD02 TheoD02 commented May 17, 2024

Hey, WDYT about generating .castor.stub.php file at the same location where castor.php is located ?

As of today, if castor.php is located at root or in .castor directory, stubs will be generated on root directory every time.

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you rebase?

@TheoD02 TheoD02 force-pushed the feat/generate_stubs_in_same_location_of_castor_file branch from b79a71a to 9c76a66 Compare May 17, 2024 08:16
@TheoD02
Copy link
Contributor Author

TheoD02 commented May 17, 2024

LGTM.

Could you rebase?

Good 👍 added changelog too 😄

@TheoD02 TheoD02 force-pushed the feat/generate_stubs_in_same_location_of_castor_file branch from 9c76a66 to bb25f31 Compare May 17, 2024 08:18
@TheoD02 TheoD02 force-pushed the feat/generate_stubs_in_same_location_of_castor_file branch from bb25f31 to 2033d8e Compare May 17, 2024 08:19
@lyrixx lyrixx merged commit 2744629 into jolicode:main May 17, 2024
9 checks passed
@lyrixx
Copy link
Member

lyrixx commented May 17, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants