Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker layer caching on Github Action #142

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 12, 2021

No description provided.

@lyrixx lyrixx changed the title Test effectiveness of docker layer caching on github action Test effectiveness of docker layer caching on Github Action Apr 12, 2021
@lyrixx lyrixx changed the title Test effectiveness of docker layer caching on Github Action Remove docker layer caching on Github Action Apr 12, 2021
@lyrixx
Copy link
Member Author

lyrixx commented Apr 12, 2021

I'm not sure this cache layer works well. This build took

  • cache restore: 0 sec
  • docker build: 1m 50 sec
  • cache store: 0 sec

Where others build took

  • cache restore: ~30 sec
  • docker build: ~ 1m 40 sec
  • cache store: ~ 45 sec

So basically, we saved about 1 minutes by not using a cache !

image

I propose to merge #139 first, make another round of test, and if it's not better, let's drop that cache (less code == less bug)

@lyrixx lyrixx requested a review from pyrech April 12, 2021 22:36
@pyrech
Copy link
Member

pyrech commented Apr 13, 2021

Yeah the Docker cache was a bit slow when I introduced it but it was still useful.

I have the feeling that after some time - when the cache become bigger and bigger - the restore step largely exceed build time from scratch.

An alternative of removing it entirely could be to reset it regularly (to not lose time by restoring old Docker images that are no longer used) but I'm not sure that is possible easily.

But yeah let see how it behaves with your recent changes 👍

@pyrech
Copy link
Member

pyrech commented Apr 13, 2021

Oh I didn't see your latest comment.
That is really strange and that was not the case at the time 😕

@lyrixx
Copy link
Member Author

lyrixx commented Apr 13, 2021

I confirm the cache does not work as expected. I remove it.

@lyrixx lyrixx merged commit 69d9e25 into main Apr 13, 2021
@lyrixx lyrixx deleted the docker-layer-cache branch April 13, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants