Fixes remaining "ts" parameters from number to string type #105
Conversation
|
@damienalexandre It's unclear how to get the tests to run correctly. I appreciate any help with that and for considering this change. Thanks. |
|
Hi, thanks for your PR! Looks like there is an issue with our TravisCI configuration, I will have a look. |
|
The tests are RED here because they are not run correctly on forks (secret variables are not exposed to avoid leak). Sorry about that. Also your PR is incomplete, can you push the new generated code too? You have to follow those steps: https://github.com/jolicode/slack-php-api/blob/master/doc/updating-sdk.md#regenerate-the-sdk Thanks! |
Also adds phpunit result cache file to gitignore list
jeremeamia
force-pushed
the
fix-remaining-ts-issues
branch
from
62b70c7
to
7b244bb
Compare
|
Added the newly generated bits. |
|
Thanks @jeremeamia! I'm going to add some tests and publish a release today. |
|
Thanks @damienalexandre! This made it like 20 times easier to get a single message by its |
* Add a test for #105, fix CS, and skip Slack tests when misconfigured * Prepare release 4.1.0 * Fix tests for PHP 7.2 and lowest deps compatibility
Fixes remaining "ts" parameters from
numbertype tostringtype. Similar issues reported for other parameters in #12, #22, #26, #27, and #75. Also adds the phpunit result cache file to gitignore list.