Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending ignoredModules to accept a function #29

Merged
merged 1 commit into from
Nov 27, 2014
Merged

Conversation

stefanpenner
Copy link
Contributor

nicely enables more dynamic addition and removal of ignoredModules at runtime.

@stefanpenner
Copy link
Contributor Author

@joliss could we get some feedback here?

@joliss
Copy link
Owner

joliss commented Nov 25, 2014

I've added a deprecation notice - I'd really prefer not to sink more time into this plugin.

My suggestion would to just let this plugin die, but if you still need to support it, I'm happy to let you and/or @rwjblue take over maintenance.

@joliss
Copy link
Owner

joliss commented Nov 25, 2014

Would be happy to give you commit bit and npm rights if you want to take over, then you can merge this and release.

@rwjblue
Copy link
Collaborator

rwjblue commented Nov 25, 2014

@joliss - Happy to do it. Can you add me to npm (I'm rwjblue there also)?

@joliss
Copy link
Owner

joliss commented Nov 25, 2014

Done - plugin is all yours. :)

@stefanpenner
Copy link
Contributor Author

I've added a deprecation notice - I'd really prefer not to sink more time into this plugin.

Well, every ember-cli user depends on this still. We plan to upgrade to the latest transpiler, but it's still further down on the list of things to do.

Ultimately, as long as you give someone else commit and publish we can maintain it until we have a chance to move to the newer transpiler.

rwjblue added a commit that referenced this pull request Nov 27, 2014
extending ignoredModules to accept a function
@rwjblue rwjblue merged commit a4cda90 into joliss:master Nov 27, 2014
@rwjblue
Copy link
Collaborator

rwjblue commented Nov 27, 2014

Published: + broccoli-es6-concatenator@0.1.11

@stefanpenner
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants