This repository has been archived by the owner on Apr 29, 2022. It is now read-only.
Add an option to make setting the imgur title optional #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was it closed? You don't want this feature? I've been running this fork for half a year now, it hasn't caused any issues. |
|
Huh, I didn't actually close this. Apparently GitHub did because I merged and deleted the 'cleanup' branch. I can't even reopen it. Could you open this again against the master branch? |
|
Github be like that sometimes. Rebased on top of master and reopened #144. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain IM software (read: Discord) handles imgur link previews differently based on if the image has a title.
Discord treats titled images as albums (example), and untitled images are inlined (example).
The flag
-n, --no-upload-title(and environment variableUPLOAD_USE_TITLE) gives user the power to choose, which might be useful for people like me, who primarily use the tool to send people screenshots over discord.P.S The PR is against v2 branch, but it should be fairly easy to backport to v1 too. Let me know if you want me to do that.