Skip to content

Commit

Permalink
Remove DiscoveredPathContainerPage
Browse files Browse the repository at this point in the history
The class DiscoveredPathContainerPage used a number of APIs in
the Eclipse Platform
[removed](eclipse-platform/eclipse.platform.ui#1563) in
[Eclipse 4.31 release](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81e406456ffae2f82fe0bb244adfdc4121c9e463/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#L595).
This class, while API, has not be used, nor usable since the CDT 4
release as it was only for CDT 3.x style projects.
The class had been deprecated since 2010.

To mitigate against the possibility that someone may have a dependency
on this old class the minor version has been bumped so that version
range can have `,8.3)` as their upper version.

Fixes eclipse-cdt#700
  • Loading branch information
jonahgraham committed Feb 8, 2024
1 parent 70dbde4 commit d1d75a8
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 819 deletions.
8 changes: 8 additions & 0 deletions NewAndNoteworthy/CHANGELOG-API.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ This section describes API removals that occurred in past releases, and upcoming

Below is the detailed descriptions of API changes and mitigation efforts API consumers need to take.

## API Changes in CDT 11.5.

### org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage removed

The class DiscoveredPathContainerPage used a number of APIs in the Eclipse Platform [removed](https://github.com/eclipse-platform/eclipse.platform.ui/pull/1563) in [Eclipse 4.31 release](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81e406456ffae2f82fe0bb244adfdc4121c9e463/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#L595).
This class, while API, has not be used, nor usable since the CDT 4 release as it was only for CDT 3.x style projects.
The class had been deprecated since 2010.

## API Changes in CDT 11.4.

### org.eclipse.tools.templates.freemarker, org.eclipse.tools.templates.freemarker.ui and org.eclipse.tools.templates.freemarker.core major version bumped
Expand Down
19 changes: 19 additions & 0 deletions build/org.eclipse.cdt.make.ui/.settings/.api_filters
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.cdt.make.ui" version="2">
<resource path="META-INF/MANIFEST.MF">
<filter comment="This class references deleted classes in Platform and this class is not reachable See https://github.com/eclipse-cdt/cdt/issues/700" id="923795461">
<message_arguments>
<message_argument value="8.3.0"/>
<message_argument value="8.2.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage">
<filter comment="This class references deleted classes in Platform and this class is not reachable See https://github.com/eclipse-cdt/cdt/issues/700" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage"/>
<message_argument value="org.eclipse.cdt.make.ui_8.3.0"/>
</message_arguments>
</filter>
</resource>
</component>
2 changes: 1 addition & 1 deletion build/org.eclipse.cdt.make.ui/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.cdt.make.ui; singleton:=true
Bundle-Version: 8.2.100.qualifier
Bundle-Version: 8.3.0.qualifier
Bundle-Activator: org.eclipse.cdt.make.internal.ui.MakeUIPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
8 changes: 0 additions & 8 deletions build/org.eclipse.cdt.make.ui/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -430,14 +430,6 @@
</extension>


<extension
point="org.eclipse.cdt.ui.PathContainerPage">
<PathContainerPage
class="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage"
icon="icons/obj16/lib_obj.gif"
id="org.eclipse.cdt.make.core.DISCOVERED_SCANNER_INFO"
name="%DiscoveredScannerInfoContainer.name"/>
</extension>
<extension
point="org.eclipse.core.runtime.preferences">
<initializer class="org.eclipse.cdt.make.internal.ui.MakeUIPreferenceInitializer"/>
Expand Down
Loading

0 comments on commit d1d75a8

Please sign in to comment.