Merge pull request #78 from AndreySBer/bugfix-77

Fix bug #77
jonan · Jan 29, 2018 · 8e2b5db · 8e2b5db
2 parents 5f549cc + af5a5a0
commit 8e2b5db
Showing 1 changed file with 5 additions and 18 deletions.
diff --git a/app/src/main/java/com/github/mobile/ui/milestone/IssueDialog.java b/app/src/main/java/com/github/mobile/ui/milestone/IssueDialog.java
@@ -73,14 +73,14 @@ public List<Issue> getIssues() {
         return repositoryIssues;
     }
 
-    private void load() {
+    public void show() {
         new ProgressDialogTask<ArrayList<Issue>>(activity) {
 
             @Override
             public ArrayList<Issue> run(Account account) throws Exception {
                 ArrayList<Issue> issues = new ArrayList<Issue>();
                 String[] repid = repository.generateId().split("/");
-                issues.addAll(service.getIssues(repid[0],repid[1], "none").execute().body());
+                issues.addAll(service.getIssues(repid[0], repid[1], "none").execute().body());
                 return issues;
             }
 
@@ -89,7 +89,9 @@ protected void onSuccess(ArrayList<Issue> all) throws Exception {
                 super.onSuccess(all);
 
                 repositoryIssues = all;
-                show();
+                IssueDialogFragment.show(activity, requestCode,
+                        activity.getString(R.string.ms_select_issue), null,
+                        repositoryIssues);
             }
 
             @Override
@@ -108,19 +110,4 @@ public void execute() {
             }
         }.execute();
     }
-
-    /**
-     * Show dialog
-     *
-     */
-    public void show() {
-        if (repositoryIssues == null) {
-            load();
-            return;
-        }
-
-        IssueDialogFragment.show(activity, requestCode,
-                activity.getString(R.string.ms_select_issue), null,
-                repositoryIssues);
-    }
 }