Skip to content

In diff-view, don't shorten numstats unnecessarily #109

Closed
ninjadrm opened this Issue Dec 9, 2012 · 3 comments

3 participants

@ninjadrm
ninjadrm commented Dec 9, 2012

diff_open() uses "--patch-with-stat" which implies "--stat" which cuts the num-stats down to 80 chars. This cuts down filenames in most of the cases, which I find hard to work with since my terminals easily have 200+ chars, so I am missing needed information although the space is there. I'd love to see diff_open use something like "-p --stat=my_current_terminal_width" instead of "--patch-with-stat".

@jonas jonas added a commit that referenced this issue Feb 19, 2013
@jonas [#109] WIP 85a9fcb
@jonas
Owner
jonas commented Feb 19, 2013

So now there's a prototype, but I am not sure I see how much information it adds.

@jonas jonas added a commit that referenced this issue Apr 30, 2013
@jonas GH-109 97e4fc6
@jonas jonas added a commit that closed this issue Apr 30, 2013
@jonas Show diff stats as wide as the terminal
Closes GH-109.
a7eb305
@jonas jonas closed this in a7eb305 Apr 30, 2013
@jonas
Owner
jonas commented Aug 4, 2013

As pointed out by @eMPee584 this breaks resizing so it will have to be reverted for now.

@jonas jonas reopened this Aug 4, 2013
@jonas jonas added a commit that closed this issue Aug 4, 2013
@jonas Only set LINES and COLUMNS environment variables for external commands
Setting the LINES/COLUMNS environment variables to a constant number
breaks ncurses' getmaxyx() logic, so dynamic resizing doesn't work as
pointed out by Marcel Partap in a comment to the fix for issue #151
(f0ad1f7#commitcomment-3528715).

As a work-around, only set LINES/COLUMNS when forking Git processes. This
way diff stats will still use the whole terminal width and resizing works
as intended.

Fixes #109
1eaf34b
@jonas jonas closed this in 1eaf34b Aug 4, 2013
@eMPee584
eMPee584 commented Aug 5, 2013

Delightful - fixes dynamic resizing and creates abundant happiness throughout the cli realm ×)
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.