Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In blame view, add option to toggle commit id #89

Open
dov opened this issue Sep 21, 2012 · 1 comment
Open

In blame view, add option to toggle commit id #89

dov opened this issue Sep 21, 2012 · 1 comment
Labels
component:blame Blame UI

Comments

@dov
Copy link

dov commented Sep 21, 2012

Sometimes it is just interesting who wrote a line and seeing more columns of the file is more interesting than seeing the commit id. Adding a toggle to the control the display of the commit would solve this. I suggest that the following options may be used for the commit:

  1. Normal (like now)
  2. Off
  3. Symbolic (show HEAD, HEAD^1, HEAD^3) etc
  4. Short(? - e.g. minimum of unique characters needed to be unique)
@jonas
Copy link
Owner

jonas commented Oct 1, 2012

Yeah, sounds like a good idea. In terms of consistency it probably makes sense to hide the commit ID by default so that it is toggled the same way in all views. For example, you can toggle the commit ID in the main view.

jonas added a commit that referenced this issue Apr 17, 2014
@jonas
view: make options private to each view
ba4c4b6 
This enables options to be toggled individually for each view and
effectively prepares for fixing issue #222 and adds rudiment support
for toggling the commit ID (issue #89).
jonas added a commit that referenced this issue Apr 23, 2014
@jonas
Make view columns configurable
31dc36c 
This introduces new settings for all column-based views to make them
configurable via tigrc. The configuration format is a simple
space-separated list of strings, each containing comma-separated
key=value pairs. This allows to enable columns such as line numbers
individually for each view (as mentioned in issue #222) and hiding the
ID column in the blame view.

Due to the difference in configuration format all old view UI display
settings are now obsolete with no graceful upgrade. However, warnings
for all obsolete settings are emitted pointing to the view column types.

References #89
Fixes #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:blame Blame UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas @dov