Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialise struct timezone in main_add_changes_commit #1291

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Initialise struct timezone in main_add_changes_commit #1291

merged 1 commit into from
Aug 31, 2023

Commits on Aug 1, 2023

  1. Initialise struct timezone 

    On musl libc gettimeofday (which is used by time_now) does not
populate the timezone struct passed to it as POSIX says:

> If tzp is not a null pointer, the behavior is unspecified.

tz_minuteswest is later multiplied by 60 which can overflow. When tig
is compiled with integer overflow hardening (as is done on Chimera
Linux) via the clang option -fsanitize=signed-integer-overflow this can
result in tig crashing due to the overflow.
    @wezm
    wezm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a1ef981 View commit details
    Browse the repository at this point in the history