Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on the use of cfg_eval #610

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Update documentation on the use of cfg_eval #610

merged 4 commits into from
Jul 3, 2023

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Jul 3, 2023

Closes #607

bors r+

@jonasbb
Add a test showing how cfg_eval can be used to gate serde_with attrib…
91630e7 
…utes

So far the story for cfg-gating serde_with attributes has not been
great, as shown in #331 or #355.
This adds a test showing how cfg_eval can be used to gate serde_with.

Part of #607
@jonasbb
Update documentation on the use of cfg_eval
495036f
bors bot added a commit that referenced this pull request Jul 3, 2023
@bors @jonasbb
Merge #610
5b111d7 
610: Update documentation on the use of cfg_eval r=jonasbb a=jonasbb

Closes #607

bors r+

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Build failed:

@jonasbb jonasbb mentioned this pull request Jul 3, 2023
Closed
@jonasbb
Copy link
Owner Author

jonasbb commented Jul 3, 2023

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2023
@bors @jonasbb
Merge #610
f022183 
610: Update documentation on the use of cfg_eval r=jonasbb a=jonasbb

Closes #607

bors r+

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Build failed:

@jonasbb
Copy link
Owner Author

jonasbb commented Jul 3, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e22dd37 into master Jul 3, 2023
19 checks passed
@bors bors bot deleted the cfg-eval branch July 3, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate use of cfg_eval
1 participant
@jonasbb